Skip to content

fix(recipes): correct PATH in dsv4-sglang Dockerfile - #8713

Merged
nv-tusharma merged 1 commit into
mainfrom
fix/dsv4-sglang-dockerfile-path
Apr 25, 2026
Merged

fix(recipes): correct PATH in dsv4-sglang Dockerfile#8713
nv-tusharma merged 1 commit into
mainfrom
fix/dsv4-sglang-dockerfile-path

Conversation

@nv-tusharma

@nv-tusharma nv-tusharma commented Apr 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Build the overlay image and confirm etcd resolves on PATH
Open in Devin Review

Summary by CodeRabbit

  • Bug Fixes
    • Fixed environment configuration to ensure system binaries are properly discoverable within the application container.

@nv-tusharma @claude
fix(recipes): correct PATH in dsv4-sglang Dockerfile
f176b25 
PATH entries must be directories. /usr/local/bin/etcd points at the
binary itself, so etcd was not resolvable on PATH.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@nv-tusharma
nv-tusharma requested review from a team as code owners April 25, 2026 00:55
@github-actions github-actions Bot added the fix label Apr 25, 2026
@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b9f83c7-6fb0-42f8-8cdd-4f46f6d7ccbc

📥 Commits

Reviewing files that changed from the base of the PR and between 222e289 and f176b25.

📒 Files selected for processing (1)
  • recipes/deepseek-v4-flash/sglang/Dockerfile.dsv4-sglang

Walkthrough

A Dockerfile environment variable correction that updates the PATH setting to reference /usr/local/bin instead of the malformed /usr/local/bin/etcd, enabling proper binary discovery for binaries copied to that directory.

Changes

Cohort / File(s) Summary
Dockerfile PATH Fix
recipes/deepseek-v4-flash/sglang/Dockerfile.dsv4-sglang		 Corrected PATH environment variable from malformed /usr/local/bin/etcd to /usr/local/bin for proper binary discoverability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides a clear summary and context but does not follow the required template structure with all expected sections (Overview, Details, Where should reviewer start, Related Issues). Restructure the description to match the template format with explicit Overview, Details, and Where should the reviewer start sections, and ensure the GitHub issue reference uses one of the action keywords (Closes/Fixes/Resolves/Relates to).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing the PATH environment variable in the dsv4-sglang Dockerfile to correctly reference the directory instead of a binary file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nv-tusharma
nv-tusharma merged commit f7a9444 into main Apr 25, 2026
62 checks passed
@nv-tusharma
nv-tusharma deleted the fix/dsv4-sglang-dockerfile-path branch April 25, 2026 01:03
nv-tusharma added a commit that referenced this pull request Apr 25, 2026
@nv-tusharma @claude
fix(recipes): correct PATH in dsv4-sglang Dockerfile (#8713)
2fb6aa1 
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
VincyZhang pushed a commit to VincyZhang/dynamo that referenced this pull request Apr 27, 2026
@nv-tusharma @claude @VincyZhang
fix(recipes): correct PATH in dsv4-sglang Dockerfile (ai-dynamo#8713)
b246d3b 
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: VincyZhang <wenxin.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrishnanPrash KrishnanPrash KrishnanPrash approved these changes

Assignees

No one assigned

Labels

fix size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nv-tusharma @KrishnanPrash